Remove forced override of package contents #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToddGrun
reviewed
Aug 14, 2024
| // is resolved. | ||
| if (Equals(GetFrameworkNameFromPath(assembliesByPrecedence[0]), GetFrameworkNameFromPath(assembliesByPrecedence[i]))) | ||
| { | ||
| assembliesToRemove.Add(assembliesByPrecedence[i - 1]); |
There was a problem hiding this comment.
(I assume it's the GroupBy usage, but if that were the case, I would have thought just realizing that result would have been easier)
There was a problem hiding this comment.
➡️ I'm going to keep the current form for ease of debugging. Will add a comment in the code explaining that.
ToddGrun
reviewed
Aug 14, 2024
| // In this example, the Microsoft.NETCore.App.Ref package is resolved first, so by taking | ||
| // the last net6.0 assembly, we ensure the assembly from System.Collections.Immutable 8.0.0 | ||
| // is resolved. | ||
| if (Equals(GetFrameworkNameFromPath(assembliesByPrecedence[0]), GetFrameworkNameFromPath(assembliesByPrecedence[i]))) |
There was a problem hiding this comment.
➡️ Moved to single evaluation of GetFrameworkNameFromPath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1155